Fix/isort python39 compatibility #142
Conversation
- Add conditional isort installation in [project.optional-dependencies] - Python 3.10+: isort >=7.0.0 - Python 3.9: isort >=5.12.0, <7.0 - Remove hardcoded isort from [tool.poetry.dev-dependencies] - Update requirements.txt with documentation comment - Maintains backwards compatibility with Python 3.9 while allowing Python 3.10+ users to use isort v7 Fixes Python 3.9 CI/CD compatibility issue with isort v7 upgrade. This PR builds on top of PR kinde-oss#126 (isort v7 upgrade) and adds Python 3.9 compatibility.
WalkthroughReplaced the single Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
dtoxvanilla1991
left a comment
dtoxvanilla1991
left a comment
There was a problem hiding this comment.
Line 34 currently pins isort>=5.12.0 unconditionally in requirements.txt, so any workflow that still relies on pip install -r requirements.txt (many CI jobs do) will keep pulling the 5.x series even on Python 3.10+. That contradicts the PR’s stated goal of allowing 3.10+ to use isort 7.
If you really expect everyone—including automation—to switch to pip install -e ".[dev]", then yes, that isort line should be removed so there isn’t a conflicting requirement. But before dropping it, confirm that no CI/CD paths still consume requirements.txt; otherwise you’ll lose isort entirely there. A safer alternative is to keep entries in requirements.txt but mirror the conditional markers already used in pyproject.toml,
3 participants
fix: make isort conditional to maintain Python 3.9 compatibility
Python 3.10+ users to use isort v7
Fixes Python 3.9 CI/CD compatibility issue with isort v7 upgrade.
This PR builds on top of PR #126 (isort v7 upgrade).
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.